Add rudimentary support for _tkinter in GraalPy#381
Draft
phkeese wants to merge 1 commit intooracle:masterfrom
Draft
Add rudimentary support for _tkinter in GraalPy#381phkeese wants to merge 1 commit intooracle:masterfrom
phkeese wants to merge 1 commit intooracle:masterfrom
Conversation
This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter. Before use, the bindings need to be built using tklib_build.py. The code was modified from existing code in PyPy's main branch. Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons. It seems like there is a bug in the `cffi` module causing a SegFault. macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled. Windows was not tested. Co-authored-by: Margarete Dippel <margarete.dippel@student.hpi.de> Co-authored-by: Tim Felgentreff <tim.felgentreff@oracle.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter. Before use, the bindings need to be built using tklib_build.py. The code was modified from existing code in PyPy's main branch.
Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons. It seems like there is a bug in the
cffimodule causing a SegFault. macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled. Windows was not tested.Tests
Running CPython's tests for
tkinterandttkshows some success, but some tests still fail, raise an error or even crash with a segmentation fault:The main culprit for the failing tests seem to be Unicode errors, PyPy's 3.8 branch seems to fix those.